Alle rapporter
Sunrise Sunset rapporterer
#141680: "incorrect score display"
fixed: Bug er blevet fixet
2
Hvad handler denne rapport om?
Hvad skete der? Vær venlig og vælg nedenunder
Visningfejl: nogle spilinformationer blev vist forkert (uden nogen særlig konsekvens for spillet)
Detaljeret beskrivelse
• Venligst beskriv display problemet. Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect• Hvilken browser bruger du?
opera
Rapporthistorik
11. okt 2024 23:15 • Biolog Psihopat • Fejlen er ikke blevet reproduceret af udviklere endnu:
12. okt 2024 2:21 • Biolog Psihopat • Fejlen er ikke blevet reproduceret af udviklere endnu:
PS. that not at the end of the game, so this is a slightly different situation compared to my next note (that image from 2nd round, when game ends at 5th round)
20. okt 2024 12:35 • giantroach • Fejlen er blevet bekræftet af udviklere:
- Isis power should be 4 instead of 6, and Apofis power should be 6 instead of 4.
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
26. okt 2024 15:32 • giantroach • Fejlen er blevet bekræftet af udviklere:
I reproduced this bug myself.
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
26. okt 2024 16:22 • giantroach • Fejlen er blevet bekræftet af udviklere:
One possible root cause is found:
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
6. nov 2024 20:00 • giantroach • Fejlen er blevet bekræftet af udviklere:
Not everything, but nearly all the doubt is solved (Fixing needs an extra work.)
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
8. nov 2024 16:49 • giantroach • Bug er blevet fixet:
This bug is fixed.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Tilføj noget til denne rapport
Vær sød at tilføje, det du finder relevant for at vi kan løse fejlen i spillet eller forstå dit forslag:
- Et andet bord-ID / træk ID
- Løste F5 problemet?
- Skete problemet flere gange? Hver gang? Tilfældigt?
- Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
