#141680: "incorrect score display"
Hvad handler denne rapport om?
Hvad skete der? Vær venlig og vælg nedenunder
Hvad skete der? Vær venlig og vælg nedenunder
Vær sød at undersøge, om der allerede er sendt en besked om emnet
Hvis ja, venligst STEM for denne rapport. Rapporter med flest stemmer er dem der får PRIORITET!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detaljeret beskrivelse
-
• Venligst kopier/indsæt fejlmeddelelsen du ser på din skærm, hvis der er en.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Venligst forklar hvad du ønsker at gøre, hvad du gjorde og hvad der skete
• Hvilken browser bruger du?
opera
-
• Venligst kopier/indsæt tekst vist på engelsk i stedet for dit sprog. Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• er der adgang til denne tekst i oversættelsessystem? Hvis ja, er det blevet oversat inden for 24 timer?
• Hvilken browser bruger du?
opera
-
• Forklar venligst dit forslag præcist og sammenfattende, så det er så let som muligt at forstå, hvad du mener.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken browser bruger du?
opera
-
• Hvad blev der vist på skærmen, da du blev blokeret (Blank skærm? Noget af spilbrugerfladen? Fejlmeddelelse?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken browser bruger du?
opera
-
• Hvilken del af reglerne blev ikke respekteret ved BGA-tilpasningen
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Er regel-brudddet synligt i e
• Hvilken browser bruger du?
opera
-
• Hvad var den spilhandling du ønskede at udføre?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Hvad forsøgte du at gøre for at udløse denne spilhandling?
-
• Hvad skete der, da du forsøgre at gøre dette (fejlmeddelelse, meddelelsesstatusbjælke, ...)?
• Hvilken browser bruger du?
opera
-
• I hvilket stadie af spillet opstod problemet (hvad var den daværende spilinstruktion)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Hvad skete der, da du forsøgte at udføre denne spilhandling (fejlmeddelelse, meddelelsesstatusbjælke, ...)?
• Hvilken browser bruger du?
opera
-
• Venligst beskriv display problemet. Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken browser bruger du?
opera
-
• Venligst kopier/indsæt tekst vist på engelsk i stedet for dit sprog. Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• er der adgang til denne tekst i oversættelsessystem? Hvis ja, er det blevet oversat inden for 24 timer?
• Hvilken browser bruger du?
opera
-
• Forklar venligst dit forslag præcist og sammenfattende, så det er så let som muligt at forstå, hvad du mener.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken browser bruger du?
opera
Rapporthistorik
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Tilføj noget til denne rapport
- Et andet bord-ID / træk ID
- Løste F5 problemet?
- Skete problemet flere gange? Hver gang? Tilfældigt?
- Hvis du har et skærmbillede af denne fejl (god øvelse), kan du bruge Imgur.com til at uploade den og kopiere/indsætte linket her.
